[mypyc] Fix exception reraising when awaiting a future #20547
Merged
+150
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1177.
Fixed incorrect behavior seen when a function compiled with mypyc awaits an expression in which a future raises an exception, eg.
It seems like this case is different from a regular async function raising an exception in that the exception raised by the future is available in the handled exception state seen by the delegating generator (meaning the outer function compiled with mypyc) even when the exception is caught in the inner function.
The delegating generator reraises the exception from the handled exception state in
CPy_YieldFromErrorHandlewhich ends up reraising an already caught exception.The fix is to also return the function early when the delegated generator throws an exception other than
StopIteration(forStopIterationit already returns), meaningresisNULLin line 71 and also in line 80. This is now consistent with the implementation in cpython which does not reraise on exception in the delegated generator (the reraising happens under labelthrow_herewhich is reached under different conditions).